Stamp seed rows with language + add --language flag #9
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
Reviewed/Confirmed
Reviewed/Duplicate
Reviewed/Invalid
Reviewed/Won't Fix
Status/Abandoned
Status/Blocked
Status/Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
project-halkyon/halkyon-curator!9
Loading…
Reference in a new issue
No description provided.
Delete branch "refs/pull/9/head"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The catalog's primary key is now (id, language), so the seed should send
language explicitly rather than leaning on the column default. DictionarySeedRow
gains a language field (default 'ja') emitted in toJson, and the seed_dictionary
bin gains a --language option (default ja). Re-seeding Japanese is unchanged;
the flag is the hook a future non-Japanese wordlist sets (that source needs its
own parser — the input here is still JMdict). 2 new tests; dry-run confirms the
language column lands in the upsert body.
Signed-off-by: Tizian 「ティツィアーン」 raisondetredev@pm.me