perf: Skip the projection passes for merged inserts that cannot change them
A merge that touched any foreign key ran the planning pass for its new rows and then the full projection pass, whose closure follows foreign keys both ways and so loads every row connected to the merged ones. In a library whose tags join its parts, one merged rating, edit, tag or new card loaded all of it: about 9.5 s on a device receiving it and 12 s on the server merging a push, for 8,000 cards. A batch that only inserts new rows (each once) and updates columns no projection reads now leaves both passes out when its inserts are proven, as local inserts are (canLeaveProjectionUnchangedByMergedInserts, on localProjectionDependenciesAreStable): each row references its parents by id, each parent visible or inserted earlier in the same batch, nothing refers to the row yet (no row, no attempted value), and no unique claim is contested. A parent inserted after its child in the batch would find the child's reference held back, which only the pass restores, so it counts only when earlier. Deletes, inserts onto rows there already and anything unproven take the passes as before. The batch's parents are still resolved together for the writes. The new tests cover a child of a visible parent, a parent and child in one batch (both through the shortcut), and a child of a merged delete and a parent arriving after its held-back child (both through the passes); dropping the parent or the reference check fails the matching test. The core, server, integration and simulation suites pass, but for two PostgreSQL tests that cannot start their database while another embedded PostgreSQL runs, with or without this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
b5450353b9
commit
9495f616c4
GPG key ID:
07F6FCF405488B64
1 changed files with 344 additions and 5 deletions
|
|
@ -0,0 +1,191 @@
|
|||
import 'package:serverpod/serverpod.dart';
|
||||
import 'package:serverpod_offline_sync_server/serverpod_offline_sync_server.dart';
|
||||
import 'package:serverpod_offline_sync_test_client/serverpod_offline_sync_test_client.dart';
|
||||
import 'package:test/test.dart';
|
||||
|
||||
import '../test_tools/client_session.dart';
|
||||
import '../test_tools/crdt_probes.dart';
|
||||
|
||||
// Merged inserts of new rows whose parents are visible, which nothing
|
||||
// refers to yet, change no projection decision, and the merge leaves the
|
||||
// projection pass out for them. Anything else still takes the pass: these
|
||||
// cover both sides.
|
||||
void main() {
|
||||
initTestClientSession();
|
||||
|
||||
CrdtMergeInsert insertOf(TableRow row, String tableName) {
|
||||
final node = const Uuid().v7obj();
|
||||
return CrdtMergeInsert(
|
||||
uuidSpaceId: testCrdtUserId,
|
||||
tableName: tableName,
|
||||
uuidRowId: row.id! as UuidValue,
|
||||
uuidNodeId: node,
|
||||
hlcDatetime: DateTime.now().toUtc(),
|
||||
hlcCounter: 0,
|
||||
data: row,
|
||||
);
|
||||
}
|
||||
|
||||
Future<void> merge(List<CrdtMergeChange> changes) =>
|
||||
session.db.mergeChanges(changes, spaceId: testCrdtUserId);
|
||||
|
||||
group('Given a set-null middle stored here,', () {
|
||||
late FkChainSetNullMiddle middle;
|
||||
|
||||
setUp(() async {
|
||||
middle = await session.db.transactionForUser(
|
||||
testCrdtUserId,
|
||||
(tx) => FkChainSetNullMiddle.db.insertRow(
|
||||
session,
|
||||
FkChainSetNullMiddle(id: const Uuid().v7obj(), name: 'middle'),
|
||||
transaction: tx,
|
||||
),
|
||||
);
|
||||
});
|
||||
|
||||
group('when a remote insert of its cascade child is merged,', () {
|
||||
late FkChainSetNullCascadeChild child;
|
||||
|
||||
setUp(() async {
|
||||
child = FkChainSetNullCascadeChild(
|
||||
id: const Uuid().v7obj(),
|
||||
name: 'child',
|
||||
setNullMiddleId: middle.id,
|
||||
);
|
||||
await merge([insertOf(child, FkChainSetNullCascadeChild.t.tableName)]);
|
||||
});
|
||||
|
||||
test('then the child is there as authored, holding nothing back.', () async {
|
||||
final visible = await FkChainSetNullCascadeChild.db.findById(
|
||||
session,
|
||||
child.id!,
|
||||
);
|
||||
expect(visible, isNotNull);
|
||||
expect(visible!.setNullMiddleId, middle.id);
|
||||
expect(
|
||||
await attemptedValue(
|
||||
rowId: child.id!,
|
||||
columnName: FkChainSetNullCascadeChild.t.setNullMiddleId.columnName,
|
||||
),
|
||||
isNull,
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
group('when the middle is deleted by a merged remote delete and then a '
|
||||
'remote insert of its cascade child is merged,', () {
|
||||
late FkChainSetNullCascadeChild child;
|
||||
|
||||
setUp(() async {
|
||||
await merge([
|
||||
CrdtMergeDelete(
|
||||
uuidSpaceId: testCrdtUserId,
|
||||
tableName: FkChainSetNullMiddle.t.tableName,
|
||||
uuidRowId: middle.id!,
|
||||
uuidNodeId: const Uuid().v7obj(),
|
||||
hlcDatetime: (await rowHlc(
|
||||
middle.id!,
|
||||
)).datetime.add(const Duration(milliseconds: 1)),
|
||||
hlcCounter: 0,
|
||||
clFlag: 2,
|
||||
reason: CrdtDataDeletedReason.userDelete,
|
||||
),
|
||||
]);
|
||||
child = FkChainSetNullCascadeChild(
|
||||
id: const Uuid().v7obj(),
|
||||
name: 'child of a deleted middle',
|
||||
setNullMiddleId: middle.id,
|
||||
);
|
||||
await merge([insertOf(child, FkChainSetNullCascadeChild.t.tableName)]);
|
||||
});
|
||||
|
||||
test('then the child is hidden with its middle.', () async {
|
||||
expect(
|
||||
await FkChainSetNullMiddle.db.findById(session, middle.id!),
|
||||
isNull,
|
||||
);
|
||||
expect(
|
||||
await FkChainSetNullCascadeChild.db.findById(session, child.id!),
|
||||
isNull,
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
group('Given a set-null grandchild merged before its middle, its foreign '
|
||||
'key held back,', () {
|
||||
late FkChainSetNullMiddle middle;
|
||||
late FkChainSetNullSetNullChild grandchild;
|
||||
|
||||
setUp(() async {
|
||||
middle = FkChainSetNullMiddle(id: const Uuid().v7obj(), name: 'late');
|
||||
grandchild = FkChainSetNullSetNullChild(
|
||||
id: const Uuid().v7obj(),
|
||||
name: 'early',
|
||||
setNullMiddleId: middle.id,
|
||||
);
|
||||
await merge([
|
||||
insertOf(grandchild, FkChainSetNullSetNullChild.t.tableName),
|
||||
]);
|
||||
final early = await FkChainSetNullSetNullChild.db.findById(
|
||||
session,
|
||||
grandchild.id!,
|
||||
);
|
||||
expect(early!.setNullMiddleId, isNull);
|
||||
});
|
||||
|
||||
group("when the middle's insert is merged,", () {
|
||||
setUp(() async {
|
||||
await merge([insertOf(middle, FkChainSetNullMiddle.t.tableName)]);
|
||||
});
|
||||
|
||||
test('then the grandchild points at it.', () async {
|
||||
final visible = await FkChainSetNullSetNullChild.db.findById(
|
||||
session,
|
||||
grandchild.id!,
|
||||
);
|
||||
expect(visible!.setNullMiddleId, middle.id);
|
||||
expect(
|
||||
await attemptedValue(
|
||||
rowId: grandchild.id!,
|
||||
columnName: FkChainSetNullSetNullChild.t.setNullMiddleId.columnName,
|
||||
),
|
||||
isNull,
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
group('Given nothing stored,', () {
|
||||
group('when a remote insert of a middle and its cascade child is merged '
|
||||
'in one batch,', () {
|
||||
late FkChainSetNullMiddle middle;
|
||||
late FkChainSetNullCascadeChild child;
|
||||
|
||||
setUp(() async {
|
||||
middle = FkChainSetNullMiddle(id: const Uuid().v7obj(), name: 'new');
|
||||
child = FkChainSetNullCascadeChild(
|
||||
id: const Uuid().v7obj(),
|
||||
name: 'new child',
|
||||
setNullMiddleId: middle.id,
|
||||
);
|
||||
await merge([
|
||||
insertOf(middle, FkChainSetNullMiddle.t.tableName),
|
||||
insertOf(child, FkChainSetNullCascadeChild.t.tableName),
|
||||
]);
|
||||
});
|
||||
|
||||
test('then both are there, the child pointing at the middle.', () async {
|
||||
expect(
|
||||
await FkChainSetNullMiddle.db.findById(session, middle.id!),
|
||||
isNotNull,
|
||||
);
|
||||
final visible = await FkChainSetNullCascadeChild.db.findById(
|
||||
session,
|
||||
child.id!,
|
||||
);
|
||||
expect(visible!.setNullMiddleId, middle.id);
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
Loading…
Reference in a new issue