halkyon-days/serverpod-offline-sync
Watch
1
0
Fork
You've already forked serverpod-offline-sync
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Author column values written by set-based updates (#147)

Browse source
This commit is contained in:
Marcelo Mendonça Soares 2026-09-17 16:18:18 -03:00 • committed by GitHub
commit 811145eda6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 195 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

7
packages/serverpod_offline_sync/lib/src/database/database.dart
View file

@ -804,7 +804,12 @@ class OfflineSyncDatabase implements Database {
final columns = columnValues.map((e) => e.column).toList();
_recorder.validateAuthoredRows(result, columns);
await _recorder.afterUpdate(result, columns, tx);
await _recorder.afterUpdate(
result,
columns,
tx,
authoredColumnValues: true,
);
if (noReturn) return <T>[];
result.forEach(_stripSpaceId);
return result;

37
packages/serverpod_offline_sync/lib/src/database/recorder.dart
View file

@ -837,11 +837,19 @@ class CrdtMutationRecorder {
}
/// Records CRDT field metadata for updated rows.
///
/// [authoredColumnValues] marks a write that reached the domain without a
/// planning pass, which is the set-based `updateWhere`. Every accepted column
/// value it carries is authored, so it overlays the attempted value a
/// projection is holding for the same field. Without the overlay the pass
/// below would read that stale attempt as the authored value and restore it
/// over the write.
Future<void> afterUpdate<T extends TableRow>(
List<T> updatedRows,
List<Column>? columns,
Transaction transaction, {
bool projectionUnchanged = false,
bool authoredColumnValues = false,
Map<MergeRowKey, Map<String, Object?>> domainBeforeUpsert = const {},
}) async {
await _foreignKeyProjector.assertVisibleTargets(updatedRows, columns, transaction);
@ -857,22 +865,29 @@ class CrdtMutationRecorder {
'updated',
transaction,
);
// Only rows returned by the physical upsert were accepted by updateWhere.
// Explicit columns author even an unchanged null; full-row passthrough
// keeps the claim behind an unchanged displayed alternative.
final authoredOverlays = <MergeFieldKey, Object?>{
for (final row in updatedRows)
if (domainBeforeUpsert.containsKey((tableName, row.id)))
if (authoredColumnValues)
for (final row in updatedRows)
for (final MapEntry(key: columnName, value: value)
in _authoredValuesFromRow(row, columns).entries)
if ((domainBeforeUpsert[(tableName, row.id)]?.containsKey(columnName) ??
false) &&
(columns != null ||
!projectionValuesEqual(
domainBeforeUpsert[(tableName, row.id)]![columnName],
value,
)))
(tableName, row.id as UuidValue, columnName): value,
(tableName, row.id as UuidValue, columnName): value
else
// Only rows returned by the physical upsert were accepted by its
// `updateWhere` predicate.
for (final row in updatedRows)
if (domainBeforeUpsert.containsKey((tableName, row.id)))
for (final MapEntry(key: columnName, value: value)
in _authoredValuesFromRow(row, columns).entries)
if ((domainBeforeUpsert[(tableName, row.id)]?.containsKey(columnName) ??
false) &&
(columns != null ||
!projectionValuesEqual(
domainBeforeUpsert[(tableName, row.id)]![columnName],
value,
)))
(tableName, row.id as UuidValue, columnName): value,
};
_uniqueResolver.validateAuthoredFields(authoredOverlays);
final implicitForeignKeyRepairFields = columns == null