halkyon-days/halkyon
Watch
1
0
Fork
You've already forked halkyon
 0
Code Issues Pull requests Projects Releases 37 Packages Wiki Activity Actions

fix(dictionary): no language goes missing while the curator updates

Browse source 
The update removed the files of sources no longer wanted first, Korean's
words from Wiktionary among them, before KRDict's replacement was
written, which on the first run after v0.16.0 came after Wiktionary's
3 GB conversion: the server unloaded Korean meanwhile, and for good if
KRDict failed. Removal now comes last, and a replaced source stays until
its replacement is there. A bare curate update, without --languages,
no longer removes every other language. A KRDict export of another
shape (the page's buttons reordered) is refused rather than written as
a dictionary of no words over Korean's. The server never unloads from
an empty dictionaries folder (a volume made anew), and a failed unload
no longer stops the files from loading.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tizian 「ティツィアーン」 <raisondetredev@pm.me>
This commit is contained in:
Tizian 「ティツィアーン」 2026-10-14 17:36:55 +02:00
commit d5fe51b296
Signed by: raisondetredev
GPG key ID: 07F6FCF405488B64
1 changed files with 84 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

13
halkyon_learn_server/lib/src/dictionary/dictionary_loader.dart
View file

@ -77,9 +77,16 @@ Future<void> _loadFolder(Session session, Directory directory) async {
// A dictionary whose file is gone goes too (a language the instance no
// longer keeps, a source the curator replaced: Korean's words from
// Wiktionary before KRDict); only when every file could be read, as an
// unreadable one may be the gone dictionary's.
if (!unreadable) {
await _unloadGone(session, held);
// unreadable one may be the gone dictionary's, and never for a folder
// with none, as a volume made anew or a mount gone wrong leaves it:
// that would unload every dictionary. Failing, it leaves the files to
// load all the same.
if (!unreadable && files.isNotEmpty) {
try {
await _unloadGone(session, held);
} on Object catch (error, st) {
failed('Unloading dictionaries whose file is gone failed.', error, st);
}
}
for (final MapEntry(key: source, value: files) in bySource.entries) {
if (files.length > 1) {