halkyon-days/halkyon
Watch
1
0
Fork
You've already forked halkyon
 0
Code Issues Pull requests Projects Releases 40 Packages Wiki Activity Actions

fix(learn,ui): the open assistant field holds still: no flicker, no sliding away, no resizing under the keyboard (ADR 0021, D69)

Browse source 
Inside a studyset the field flickered as it opened and closed: the
floating location switched between a raised centre and the centre,
which Scaffold animates by scaling the button out and in. It keeps one
location now, raised above the licence line by padding. While open it
no longer slides away as the studyset or the Library scrolls
(ScrollHidingFab.pinned, new), and the keyboard covers Home, the
Library, a studyset and a session rather than shrinking them; the field
lifts itself by as much of the keyboard as reaches above it.
NavigationFrame no longer resizes for the keyboard itself, leaving it
to each tab's own scaffold, which still does by default (Todo's,
Train's and Meditate's tests pass unchanged).

Whats-New: Inside a studyset, the question field opens without flickering, stays while you scroll, and the screen no longer jumps when the keyboard comes.
Whats-New-De: In einem Lernset öffnet sich das Fragefeld ohne Flackern, bleibt beim Scrollen stehen, und der Bildschirm springt nicht mehr, wenn die Tastatur kommt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tizian 「ティツィアーン」 <raisondetredev@pm.me>
This commit is contained in:
Tizian 「ティツィアーン」 2026-11-04 21:15:48 +01:00
commit bc4953aaf8
Signed by: raisondetredev
GPG key ID: 07F6FCF405488B64
2 changed files with 255 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

5
packages/halkyon_ui/lib/src/widget/navigation_frame.dart
View file

@ -152,6 +152,11 @@ class _NavigationFrameState() extends State<NavigationFrame> {
// it, as iOS 26's tab bar floats over content; their lists end
// with room for it (the body's bottom padding says how much).
extendBody: !widget.hidesNavigationBar,
// The keyboard is each screen's own to make way for, its own
// scaffold resizing as it does by default: a screen with a field
// floating over it keeps its size and lifts the field instead
// (Halkyon Learn's ADR 0021, D69).
resizeToAvoidBottomInset: false,
body: widget.child,
// Without the bar, a strip as high as the system's own bar, in
// the screen's background, keeps every screen inside clear of

16
packages/halkyon_ui/lib/src/widget/scroll_hiding_fab.dart
View file

@ -7,7 +7,8 @@ import 'package:material_ui/material_ui.dart';
/// floating action button); the scrolling in that screen moves it.
///
/// While hidden, the button can't be tapped through its fading ghost. A list
/// short enough not to scroll keeps it in view: it covers nothing there.
/// short enough not to scroll keeps it in view: it covers nothing there, and
/// so does [pinned].
class const ScrollHidingFab({
/// The button; none when null, as in windows that put the action in the
/// app bar instead.
@ -15,6 +16,10 @@ class const ScrollHidingFab({
/// The screen, given the button to place.
required final Widget Function(BuildContext context, Widget? fab) builder,
/// Whether the button stays whatever the scrolling, as while it is a field
/// being written in, which mustn't slide away under the person's typing.
final bool pinned = false,
super.key,
}) extends StatefulWidget {
@override
@ -27,7 +32,7 @@ class _ScrollHidingFabState() extends State<ScrollHidingFab> {
bool _onScroll(UserScrollNotification notification) {
// Only the screen's own vertical scrolling: a sideways swipe between
// tabs moves nothing.
if (notification.metrics.axis != Axis.vertical) {
if (notification.metrics.axis != Axis.vertical || widget.pinned) {
return false;
}
final visible = switch (notification.direction) {
@ -46,6 +51,7 @@ class _ScrollHidingFabState() extends State<ScrollHidingFab> {
@override
Widget build(BuildContext context) {
final fab = widget.fab;
final visible = _visible || widget.pinned;
return NotificationListener<UserScrollNotification>(
onNotification: _onScroll,
child: widget.builder(
@ -57,11 +63,11 @@ class _ScrollHidingFabState() extends State<ScrollHidingFab> {
curve: Curves.easeOut,
// Twice its own height clears the window's edge whatever
// the button's size.
offset: _visible ? Offset.zero : const Offset(0, 2),
offset: visible ? Offset.zero : const Offset(0, 2),
child: AnimatedOpacity(
duration: const Duration(milliseconds: 200),
opacity: _visible ? 1 : 0,
child: IgnorePointer(ignoring: !_visible, child: fab),
opacity: visible ? 1 : 0,
child: IgnorePointer(ignoring: !visible, child: fab),
),
),
),