halkyon-days/halkyon
Watch
1
0
Fork
You've already forked halkyon
 0
Code Issues Pull requests Projects Releases 37 Packages Wiki Activity Actions

fix(todo): editing a project keeps its Display

Browse source 
Edit project built the project anew from its name, colour and position,
so saving it reset its Display (layout, grouping, sorting, filters) to
the first one. It now changes the name and colour of the project as it
is.

Whats-New: Editing a project no longer resets its Display.
Whats-New-De: Ein Projekt zu bearbeiten setzt seine Anzeige nicht mehr zurück.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tizian 「ティツィアーン」 <raisondetredev@pm.me>
This commit is contained in:
Tizian 「ティツィアーン」 2026-11-04 20:36:00 +01:00
commit b043d5ef9e
Signed by: raisondetredev
GPG key ID: 07F6FCF405488B64
2 changed files with 38 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
apps/todo/halkyon_todo_flutter/lib/src/feature/project/widget/project_dialogs.dart
View file

@ -19,11 +19,13 @@ Future<ProjectContent?> editProject(
color: current?.color ?? PaletteColor.cobalt,
);
return switch (named) {
(:final name, :final color) => ProjectContent(
name: name,
color: color,
position: current?.position ?? 0,
),
// The rest kept as it is: building it anew had reset the project's
// Display (the developer's review, 4 Nov 2026).
(:final name, :final color) =>
(current ?? ProjectContent(name: name)).copyWith(
name: name,
color: () => color,
),
null => null,
};
}

31
apps/todo/halkyon_todo_flutter/test/app/todo_app_test.dart
View file

@ -1918,6 +1918,37 @@ void main() {
expect(await tester.runAsync(() => tasks().all()), isEmpty);
});
testWidgets("editing a project keeps its Display (the developer's "
'review, 4 Nov 2026)', (tester) async {
await start(tester, usedBefore: true);
final projects = ProjectRepository(projectRows, keys);
await tester.runAsync(
() => projects.save(
const ProjectContent(
name: 'Garden',
view: ProjectView(layout: ProjectLayout.board),
),
),
);
projectRows.bringRemoteChanges();
await goTab(tester, 'Browse');
await tester.tap(find.text('Garden'));
await tester.pumpAndSettle();
await tester.tap(find.byTooltip('More'));
await tester.pumpAndSettle();
await tester.tap(find.text('Edit project'));
await tester.pumpAndSettle();
await tester.enterText(find.byType(TextField).first, 'Yard');
await tester.tap(find.text('Save'));
await tester.pumpAndSettle();
final stored = await tester.runAsync(projects.all);
final yard = stored!.singleWhere((p) => !p.inbox).content;
expect(yard?.name, 'Yard');
expect(yard?.view, const ProjectView(layout: ProjectLayout.board));
});
testWidgets("a project's screen washes in its own colour, as a "
"studyset's in Learn; one without keeps Todo's strawberry", (
tester,