halkyon-days/halkyon
Watch
1
0
Fork
You've already forked halkyon
 0
Code Issues Pull requests Projects Releases 37 Packages Wiki Activity Actions

feat(base)!: a handle at password sign-up (ADR 0020, D26, D28–D30)

Browse source 
Every new account gets a handle, and an account without one gets its
first as it sets a password. The handle is private until its person
goes public (D5).

- `passwordSignIn.signUp` takes a handle. `passwordSignIn.checkHandle`
  says whether a sign-up could take one, only while that sign-up's
  mailed code waits (`codeExpired` otherwise), counted per code request
  (30 an hour) and per network (60) (D29). Members ask the register.
- `password.set` takes the first handle of an account without one
  (D28); `SignInWays.handle` tells the app whether there is one.
- Each checks the handle before the code is used, so a refusal leaves
  the code for another try. An existing account at the address keeps
  its own handle where it has one, and the typed handle is still
  checked, so the answer says nothing about the address.
- `first_handle.dart` holds what SimpleLogin, the keys and passwords
  share: `refusalOfNewHandle`, `insertFirstProfile`, `hasHandle`.
- halkyon_app: one `HandleField` with its `HandleCheckCubit` (asked
  300 ms after typing pauses, only about the handle typed last; the
  instance's suggestion is free without asking) (D30). The password
  setup asks for the handle between the phrase check and the code, and
  a refusal at the code sends back to it. SimpleLogin's sign-up and
  keys steps use the same field and now check as it is typed.
- The module's README and ADR 0020 (D29, D30, the built state) amended.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tizian 「ティツィアーン」 <raisondetredev@pm.me>
This commit is contained in:
Tizian 「ティツィアーン」 2026-10-24 18:09:04 +02:00
commit 630965d920
Signed by: raisondetredev
GPG key ID: 07F6FCF405488B64
3 changed files with 2305 additions and 395 deletions
Download patch file Download diff file Expand all files Collapse all files

89
packages/halkyon_app/test/password/bloc/account_setup_cubit_test.dart
View file

@ -43,6 +43,7 @@ void main() {
AccountSetupMode mode, {
String? address,
bool hasAddress = false,
bool hasHandle = false,
String? phrase,
}) {
final cubit = AccountSetupCubit(
@ -51,6 +52,7 @@ void main() {
language: 'en',
address: address,
hasAddress: hasAddress,
hasHandle: hasHandle,
phrase: phrase,
);
addTearDown(cubit.close);
@ -63,9 +65,9 @@ void main() {
];
test('creates an account: the address, the password twice, the phrase '
'shown and three words typed back, then the code by mail, the '
'authenticator and the recovery codes, signed in only at the '
'end', () async {
'shown and three words typed back, then the handle while the code '
'mailed travels (ADR 0020, D29), the code, the authenticator and the '
'recovery codes, signed in only at the end', () async {
final cubit = setUpAs(AccountSetupMode.signUp);
expect(cubit.state, at(AccountSetupStep.address));
@ -121,12 +123,29 @@ void main() {
isFalse,
),
at(AccountSetupStep.phraseCheck, busy: true),
at(AccountSetupStep.mailCode, busy: true),
at(AccountSetupStep.mailCode),
at(AccountSetupStep.handle, busy: true),
at(AccountSetupStep.handle),
],
);
expect(gateway.calls, ['sendCode']);
// Checked as it is typed, against the code mailed for it.
expect(await cubit.checkHandle('admin'), HandleProblem.reserved);
expect(await cubit.checkHandle('anna'), isNull);
expect(gateway.calls, [
'sendCode',
'checkSignUpHandle',
'checkSignUpHandle',
]);
cubit.handleEntered(' @ ');
expect(
cubit.state,
at(AccountSetupStep.handle, problem: PasswordProblem.handleInvalid),
);
cubit.handleEntered(' @anna ');
expect(cubit.state, at(AccountSetupStep.mailCode));
expect(cubit.state.handle, 'anna');
await cubit.mailCodeEntered('CODE-9');
expect(
cubit.state,
@ -166,6 +185,35 @@ void main() {
SignedIn(authUserId: account.person, isIdentified: true),
);
expect(account.password, 'correct horse');
expect(gateway.handles[account.person], 'anna');
});
test('a handle taken meanwhile goes back to the handle, saying so, the '
'code left for the next', () async {
final cubit = setUpAs(AccountSetupMode.signUp)
..addressEntered('anna@example.org');
await cubit.passwordEntered('correct horse', 'correct horse');
cubit.phraseWrittenDown();
await cubit.phraseChecked(wordsAsked(cubit.state));
expect(await cubit.checkHandle('anna'), isNull);
cubit.handleEntered('anna');
gateway.handles['someone-else'] = 'Anna';
final code = gateway.codeFor('anna@example.org');
await cubit.mailCodeEntered(code);
expect(
cubit.state,
at(AccountSetupStep.handle, problem: PasswordProblem.handleTaken),
);
expect(gateway.accounts, isEmpty);
cubit.handleEntered('anna_m');
await cubit.mailCodeEntered(code);
expect(cubit.state, at(AccountSetupStep.authenticator));
expect(
gateway.handles[gateway.accounts['anna@example.org']!.person],
'anna_m',
);
});
test('an address that has an account already goes back to the address, '
@ -180,6 +228,7 @@ void main() {
await cubit.passwordEntered('another horse', 'another horse');
cubit.phraseWrittenDown();
await cubit.phraseChecked(wordsAsked(cubit.state));
cubit.handleEntered('anna');
await cubit.mailCodeEntered(gateway.codeFor('anna@example.org'));
@ -191,7 +240,8 @@ void main() {
});
test('gives one signed in with GitHub a password with an address a code '
'proves, the session staying theirs (ADR 0017, D2)', () async {
'proves, the session staying theirs (ADR 0017, D2), and their first '
'handle (ADR 0020, D28)', () async {
await auth.switchToGitHub();
final person = (auth.status as SignedIn).authUserId;
final cubit = setUpAs(AccountSetupMode.setPassword)
@ -199,6 +249,11 @@ void main() {
await cubit.passwordEntered('correct horse', 'correct horse');
cubit.phraseWrittenDown();
await cubit.phraseChecked(wordsAsked(cubit.state));
expect(cubit.state, at(AccountSetupStep.handle));
// Checked as theirs: no code request names a sign-up.
expect(await cubit.checkHandle('anna'), isNull);
expect(gateway.calls.last, 'checkHandle');
cubit.handleEntered('anna');
expect(cubit.state, at(AccountSetupStep.mailCode));
await cubit.mailCodeEntered(gateway.codeFor('anna@example.org'));
@ -208,6 +263,24 @@ void main() {
expect(cubit.state, at(AccountSetupStep.done));
expect(gateway.accountOf(person).finished, isTrue);
expect((auth.status as SignedIn).authUserId, person);
expect(gateway.handles[person], 'anna');
});
test('asks no handle of a signed-in person who has one, and sends '
'none', () async {
await auth.switchToGitHub();
final person = (auth.status as SignedIn).authUserId;
gateway.handles[person] = 'anna';
final cubit = setUpAs(AccountSetupMode.setPassword, hasHandle: true)
..addressEntered('anna@example.org');
await cubit.passwordEntered('correct horse', 'correct horse');
cubit.phraseWrittenDown();
await cubit.phraseChecked(wordsAsked(cubit.state));
expect(cubit.state, at(AccountSetupStep.mailCode));
await cubit.mailCodeEntered(gateway.codeFor('anna@example.org'));
expect(cubit.state, at(AccountSetupStep.authenticator));
expect(gateway.handles[person], 'anna');
});
test('gives a signed-in person with an address their first password only '
@ -220,6 +293,7 @@ void main() {
await first.passwordEntered('correct horse', 'correct horse');
first.phraseWrittenDown();
await first.phraseChecked(wordsAsked(first.state));
first.handleEntered('anna');
await first.mailCodeEntered(gateway.codeFor('anna@example.org'));
// An address and no password, as codes by mail left accounts.
gateway.accountOf(person)
@ -230,6 +304,7 @@ void main() {
AccountSetupMode.setPassword,
address: 'anna@example.org',
hasAddress: true,
hasHandle: true,
);
expect(cubit.state, at(AccountSetupStep.password));
await cubit.passwordEntered('another horse', 'another horse');
@ -260,6 +335,7 @@ void main() {
await cubit.passwordEntered('correct horse', 'correct horse');
cubit.phraseWrittenDown();
await cubit.phraseChecked(wordsAsked(cubit.state));
cubit.handleEntered('gina');
final code = gateway.codeFor('gina@example.org');
await cubit.mailCodeEntered(code);
@ -286,6 +362,7 @@ void main() {
await cubit.passwordEntered('another horse', 'another horse');
cubit.phraseWrittenDown();
await cubit.phraseChecked(wordsAsked(cubit.state));
cubit.handleEntered('ben');
await cubit.mailCodeEntered(gateway.codeFor('anna@example.org'));

80
packages/halkyon_app/test/password/data/password_repository_test.dart
View file

@ -268,6 +268,7 @@ void main() {
address: 'ben@example.org',
request: request,
code: gateway.codeFor('ben@example.org'),
handle: 'ben',
);
expect(pending.needsAuthenticator, isTrue);
@ -293,10 +294,76 @@ void main() {
address: 'anna@example.org',
request: request,
code: gateway.codeFor('anna@example.org'),
handle: 'anna_again',
),
failsWith(PasswordProblem.passwordExists),
);
});
test('checks the handle against the code mailed for the sign-up, and '
'for nothing else (ADR 0020, D29)', () async {
final request = await passwords.sendCode(
'ben@example.org',
language: 'en',
purpose: MailCodePurpose.signUp,
);
gateway.handles['someone-else'] = 'anna';
expect(
await passwords.checkSignUpHandle(request: request, handle: 'ben'),
isNull,
);
expect(
await passwords.checkSignUpHandle(request: request, handle: 'Anna'),
HandleProblem.taken,
);
final reset = await passwords.sendCode(
'ben@example.org',
language: 'en',
purpose: MailCodePurpose.accountReset,
);
await expectLater(
passwords.checkSignUpHandle(request: reset, handle: 'ben'),
failsWith(PasswordProblem.mailCodeExpired),
);
expect(gateway.handlesChecked, ['ben', 'Anna']);
});
test('is refused a handle taken meanwhile before the code is used, '
'which signs up with another', () async {
final material = await passwords.makePassword('a new password');
final request = await passwords.sendCode(
'ben@example.org',
language: 'en',
purpose: MailCodePurpose.signUp,
);
gateway.handles['someone-else'] = 'ben';
final code = gateway.codeFor('ben@example.org');
await expectLater(
passwords.signUp(
material,
address: 'ben@example.org',
request: request,
code: code,
handle: 'ben',
),
failsWith(PasswordProblem.handleTaken),
);
expect(gateway.accounts, isEmpty);
await passwords.signUp(
material,
address: 'ben@example.org',
request: request,
code: code,
handle: 'ben_k',
);
expect(
gateway.handles[gateway.accounts['ben@example.org']!.person],
'ben_k',
);
});
});
group('signed in', () {
@ -310,11 +377,23 @@ void main() {
);
final material = await passwords.makePassword('her password');
// Without the handle it lacks, before the code is used (ADR 0020,
// D28).
await expectLater(
passwords.setPassword(
material,
address: 'dana@example.org',
request: request,
code: gateway.codeFor('dana@example.org'),
),
failsWith(PasswordProblem.handleInvalid),
);
await passwords.setPassword(
material,
address: 'dana@example.org',
request: request,
code: gateway.codeFor('dana@example.org'),
handle: 'dana',
);
expect(
@ -323,6 +402,7 @@ void main() {
);
expect(keys.kept['github-person'], material.keys);
expect(addresses.addresses['github-person'], 'dana@example.org');
expect(gateway.handles['github-person'], 'dana');
});
test('someone signed up anew gets new keys, never the keys kept on the '

107
packages/halkyon_app/test/password/widget/password_sheets_test.dart
View file

@ -237,7 +237,8 @@ void main() {
});
testWidgets('creates an account: the phrase written down and checked '
'before the code, then the authenticator', (tester) async {
'before the code, the handle chosen while it travels (ADR 0020, '
'D29), then the authenticator', (tester) async {
await start(tester);
await tester.tap(find.text('Create an account'));
await tester.pumpAndSettle();
@ -270,6 +271,28 @@ void main() {
await typeCheckedWords(tester, fakePhrase);
await tapButton(tester, 'Continue');
expect(
find.textContaining('A code is on its way to ben@example.org.'),
findsOneWidget,
);
await tester.enterText(field('Handle'), 'admin');
await tester.pump();
expect(find.text('Checking…'), findsOneWidget);
await tester.pump(HandleCheckCubit.pause);
await tester.pumpAndSettle();
expect(
find.text('This handle is kept for the instance.'),
findsOneWidget,
);
// A handle refused goes no further.
await tapButton(tester, 'Continue');
expect(field('Code from the email'), findsNothing);
await tester.enterText(field('Handle'), 'ben');
await tester.pump(HandleCheckCubit.pause);
await tester.pumpAndSettle();
expect(find.text('@ben is free'), findsOneWidget);
await tapButton(tester, 'Continue');
await tester.enterText(
field('Code from the email'),
dependencies.passwordGateway.codeFor('ben@example.org'),
@ -287,6 +310,41 @@ void main() {
expect(ben.password, 'a new password');
expect(ben.finished, isTrue);
expect(dependencies.keys.kept.keys, [ben.person]);
expect(dependencies.passwordGateway.handles[ben.person], 'ben');
});
testWidgets('a handle taken while the code travels is asked again, the '
'code kept', (tester) async {
await start(tester);
await tester.tap(find.text('Create an account'));
await tester.pumpAndSettle();
await tester.enterText(field('Email address'), 'ben@example.org');
await tapButton(tester, 'Continue');
await tester.enterText(field('New password'), 'a new password');
await tester.enterText(field('New password again'), 'a new password');
await tapButton(tester, 'Continue');
await tapButton(tester, "I've written it down");
await typeCheckedWords(tester, fakePhrase);
await tapButton(tester, 'Continue');
await tester.enterText(field('Handle'), 'ben');
await tester.pump(HandleCheckCubit.pause);
await tester.pumpAndSettle();
await tapButton(tester, 'Continue');
dependencies.passwordGateway.handles['someone-else'] = 'ben';
final code = dependencies.passwordGateway.codeFor('ben@example.org');
await tester.enterText(field('Code from the email'), code);
await tapButton(tester, 'Continue');
expect(find.text('Someone else has this handle.'), findsOneWidget);
await tester.enterText(field('Handle'), 'ben_k');
await tester.pump(HandleCheckCubit.pause);
await tester.pumpAndSettle();
expect(find.text('Someone else has this handle.'), findsNothing);
await tapButton(tester, 'Continue');
await tester.enterText(field('Code from the email'), code);
await tapButton(tester, 'Continue');
expect(field('Code from your authenticator app'), findsOneWidget);
});
testWidgets('gets back in with the recovery phrase', (tester) async {
@ -526,6 +584,53 @@ void main() {
expect(find.text('Change password'), findsNothing);
});
/// Sets up a password for the GitHub account signed in, up to the step
/// after the phrase.
Future<void> setUpPassword(WidgetTester tester) async {
await show(tester);
await tester.tap(find.text('Set up a password'));
await tester.pumpAndSettle();
await tester.enterText(field('Email address'), 'gina@example.org');
await tapButton(tester, 'Continue');
await tester.enterText(field('New password'), 'a new password');
await tester.enterText(field('New password again'), 'a new password');
await tapButton(tester, 'Continue');
await tapButton(tester, "I've written it down");
await typeCheckedWords(tester, fakePhrase);
await tapButton(tester, 'Continue');
}
testWidgets('asks one signed in with GitHub without a handle for their '
'first with the password (ADR 0020, D28)', (tester) async {
await gateway.switchToGitHub();
final person = (gateway.status as SignedIn).authUserId;
await setUpPassword(tester);
await tester.enterText(field('Handle'), 'gina');
await tester.pump(HandleCheckCubit.pause);
await tester.pumpAndSettle();
expect(find.text('@gina is free'), findsOneWidget);
await tapButton(tester, 'Continue');
await tester.enterText(
field('Code from the email'),
dependencies.passwordGateway.codeFor('gina@example.org'),
);
await tapButton(tester, 'Continue');
expect(field('Code from your authenticator app'), findsOneWidget);
expect(dependencies.passwordGateway.handles[person], 'gina');
});
testWidgets('asks no handle of one who has one', (tester) async {
await gateway.switchToGitHub();
final person = (gateway.status as SignedIn).authUserId;
dependencies.passwordGateway.handles[person] = 'gina';
await setUpPassword(tester);
expect(field('Handle'), findsNothing);
expect(field('Code from the email'), findsOneWidget);
});
testWidgets('warns that a session was ended for its wrong proofs, until '
'dismissed', (tester) async {
final anna = dependencies.passwordGateway.addAccount(