halkyon-days/halkyon
Watch
1
0
Fork
You've already forked halkyon
 0
Code Issues Pull requests Projects Releases 37 Packages Wiki Activity Actions

fix(release): the dry run goes on without snapcraft rather than crashing
All checks were successful
CI / check (push) Successful in 38m27s
Details
CI / deploy (push) Successful in 56s
Details

Browse source 
Where snapcraft is missing, the release is refused already; asking it for
its login then threw, so the dry run stopped before listing the rest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tizian 「ティツィアーン」 <raisondetredev@pm.me>
This commit is contained in:
Tizian 「ティツィアーン」 2026-10-31 19:36:35 +01:00
commit 50c0d28194
Signed by: raisondetredev
GPG key ID: 07F6FCF405488B64
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tool/src/release/releaser.dart
View file

@ -835,7 +835,10 @@ final class Releaser({
_refuse('No JDK found (java, keytool).'); _refuse('No JDK found (java, keytool).');
} }
_environment['PATH'] = '$jdk:${_environment['PATH'] ?? ''}'; _environment['PATH'] = '$jdk:${_environment['PATH'] ?? ''}';
if (app.snap?.storeChannel case final channel? when channel.isNotEmpty) { // Asked only where snapcraft is there: without, the release was
// refused above, and the dry run goes on to say what else it would.
if (app.snap?.storeChannel case final channel?
when channel.isNotEmpty && _which('snapcraft') != null) {
final whoami = await Process.run('snapcraft', ['whoami']); final whoami = await Process.run('snapcraft', ['whoami']);
if (!RegExp( if (!RegExp(
r'^username:\s*\S', r'^username:\s*\S',