halkyon-days/halkyon
Watch
1
0
Fork
You've already forked halkyon
 0
Code Issues Pull requests Projects Releases 40 Packages Wiki Activity Actions

refactor(learn): own rows name shared content by its ID alone

Browse source 
ADR 0044, D26. The sync engine links no row of one space to a row of
another: a reference across spaces is blanked, on the device and on the
server alike (found by experiment, 11 Nov 2026). Reviews, card, note and
path tags, PDF readings and path answers are the person's own (D2, D25)
but will name cards, notes, paths, steps and PDFs of spaces they share,
so those six tables keep their columns without the relation. Every
gateway already deletes them as it deletes what they name.

The migration drops the nine foreign keys of those tables and adds the
three to `tag` again, which Serverpod numbers anew; no column or row
changes. The synced tables' hash covers foreign keys, so released apps
stop syncing with a server that has it until they update: deploy it
together with a release of Learn.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tizian 「ティツィアーン」 <raisondetredev@pm.me>
This commit is contained in:
Tizian 「ティツィアーン」 2026-11-11 12:27:15 +01:00
commit 358d983011
Signed by: raisondetredev
GPG key ID: 07F6FCF405488B64
5 changed files with 32974 additions and 1147 deletions
Download patch file Download diff file Expand all files Collapse all files

10757
apps/learn/halkyon_learn_server/migrations/20261111110923694-own-rows-by-id/definition.json Normal file
View file

File diff suppressed because it is too large Load diff

2529
apps/learn/halkyon_learn_server/migrations/20261111110923694-own-rows-by-id/definition.sql Normal file
View file

File diff suppressed because it is too large Load diff

4303
apps/learn/halkyon_learn_server/migrations/20261111110923694-own-rows-by-id/definition_project.json Normal file
View file

File diff suppressed because it is too large Load diff

172
apps/learn/halkyon_learn_server/migrations/20261111110923694-own-rows-by-id/migration.json Normal file
View file

@ -0,0 +1,172 @@
{
"__className__": "serverpod.DatabaseMigration",
"actions": [
{
"__className__": "serverpod.DatabaseMigrationAction",
"type": "alterTable",
"alterTable": {
"__className__": "serverpod.TableMigration",
"name": "card_tag",
"schema": "public",
"addColumns": [],
"deleteColumns": [],
"modifyColumns": [],
"addIndexes": [],
"deleteIndexes": [],
"addForeignKeys": [
{
"__className__": "serverpod.ForeignKeyDefinition",
"constraintName": "card_tag_fk_1",
"columns": [
"tagId"
],
"referenceTable": "tag",
"referenceTableSchema": "public",
"referenceColumns": [
"id"
],
"onUpdate": 3,
"onDelete": 4,
"deferrable": "initiallyDeferred"
}
],
"deleteForeignKeys": [
"card_tag_fk_2",
"card_tag_fk_1"
],
"warnings": []
}
},
{
"__className__": "serverpod.DatabaseMigrationAction",
"type": "alterTable",
"alterTable": {
"__className__": "serverpod.TableMigration",
"name": "learning_path_answer",
"schema": "public",
"addColumns": [],
"deleteColumns": [],
"modifyColumns": [],
"addIndexes": [],
"deleteIndexes": [],
"addForeignKeys": [],
"deleteForeignKeys": [
"learning_path_answer_fk_1"
],
"warnings": []
}
},
{
"__className__": "serverpod.DatabaseMigrationAction",
"type": "alterTable",
"alterTable": {
"__className__": "serverpod.TableMigration",
"name": "learning_path_tag",
"schema": "public",
"addColumns": [],
"deleteColumns": [],
"modifyColumns": [],
"addIndexes": [],
"deleteIndexes": [],
"addForeignKeys": [
{
"__className__": "serverpod.ForeignKeyDefinition",
"constraintName": "learning_path_tag_fk_1",
"columns": [
"tagId"
],
"referenceTable": "tag",
"referenceTableSchema": "public",
"referenceColumns": [
"id"
],
"onUpdate": 3,
"onDelete": 4,
"deferrable": "initiallyDeferred"
}
],
"deleteForeignKeys": [
"learning_path_tag_fk_2",
"learning_path_tag_fk_1"
],
"warnings": []
}
},
{
"__className__": "serverpod.DatabaseMigrationAction",
"type": "alterTable",
"alterTable": {
"__className__": "serverpod.TableMigration",
"name": "note_tag",
"schema": "public",
"addColumns": [],
"deleteColumns": [],
"modifyColumns": [],
"addIndexes": [],
"deleteIndexes": [],
"addForeignKeys": [
{
"__className__": "serverpod.ForeignKeyDefinition",
"constraintName": "note_tag_fk_1",
"columns": [
"tagId"
],
"referenceTable": "tag",
"referenceTableSchema": "public",
"referenceColumns": [
"id"
],
"onUpdate": 3,
"onDelete": 4,
"deferrable": "initiallyDeferred"
}
],
"deleteForeignKeys": [
"note_tag_fk_2",
"note_tag_fk_1"
],
"warnings": []
}
},
{
"__className__": "serverpod.DatabaseMigrationAction",
"type": "alterTable",
"alterTable": {
"__className__": "serverpod.TableMigration",
"name": "pdf_reading",
"schema": "public",
"addColumns": [],
"deleteColumns": [],
"modifyColumns": [],
"addIndexes": [],
"deleteIndexes": [],
"addForeignKeys": [],
"deleteForeignKeys": [
"pdf_reading_fk_1"
],
"warnings": []
}
},
{
"__className__": "serverpod.DatabaseMigrationAction",
"type": "alterTable",
"alterTable": {
"__className__": "serverpod.TableMigration",
"name": "review_log",
"schema": "public",
"addColumns": [],
"deleteColumns": [],
"modifyColumns": [],
"addIndexes": [],
"deleteIndexes": [],
"addForeignKeys": [],
"deleteForeignKeys": [
"review_log_fk_1"
],
"warnings": []
}
}
],
"warnings": [],
"migrationApiVersion": 1
}

118
apps/learn/halkyon_learn_server/migrations/20261111110923694-own-rows-by-id/migration.sql Normal file
View file

@ -0,0 +1,118 @@
BEGIN;
--
-- ACTION ALTER TABLE
--
ALTER TABLE "card_tag" DROP CONSTRAINT IF EXISTS "card_tag_fk_2";
ALTER TABLE "card_tag" DROP CONSTRAINT IF EXISTS "card_tag_fk_1";
--
-- ACTION ALTER TABLE
--
ALTER TABLE "learning_path_answer" DROP CONSTRAINT IF EXISTS "learning_path_answer_fk_1";
--
-- ACTION ALTER TABLE
--
ALTER TABLE "learning_path_tag" DROP CONSTRAINT IF EXISTS "learning_path_tag_fk_2";
ALTER TABLE "learning_path_tag" DROP CONSTRAINT IF EXISTS "learning_path_tag_fk_1";
--
-- ACTION ALTER TABLE
--
ALTER TABLE "note_tag" DROP CONSTRAINT IF EXISTS "note_tag_fk_2";
ALTER TABLE "note_tag" DROP CONSTRAINT IF EXISTS "note_tag_fk_1";
--
-- ACTION ALTER TABLE
--
ALTER TABLE "pdf_reading" DROP CONSTRAINT IF EXISTS "pdf_reading_fk_1";
--
-- ACTION ALTER TABLE
--
ALTER TABLE "review_log" DROP CONSTRAINT IF EXISTS "review_log_fk_1";
--
-- ACTION CREATE FOREIGN KEY
--
ALTER TABLE ONLY "card_tag"
ADD CONSTRAINT "card_tag_fk_1"
FOREIGN KEY("tagId")
REFERENCES "tag"("id")
ON DELETE CASCADE
ON UPDATE NO ACTION
DEFERRABLE INITIALLY DEFERRED;
--
-- ACTION CREATE FOREIGN KEY
--
ALTER TABLE ONLY "learning_path_tag"
ADD CONSTRAINT "learning_path_tag_fk_1"
FOREIGN KEY("tagId")
REFERENCES "tag"("id")
ON DELETE CASCADE
ON UPDATE NO ACTION
DEFERRABLE INITIALLY DEFERRED;
--
-- ACTION CREATE FOREIGN KEY
--
ALTER TABLE ONLY "note_tag"
ADD CONSTRAINT "note_tag_fk_1"
FOREIGN KEY("tagId")
REFERENCES "tag"("id")
ON DELETE CASCADE
ON UPDATE NO ACTION
DEFERRABLE INITIALLY DEFERRED;
--
-- MIGRATION VERSION FOR halkyon_learn
--
INSERT INTO "serverpod_migrations" ("module", "version", "timestamp")
VALUES ('halkyon_learn', '20261111110923694-own-rows-by-id', now())
ON CONFLICT ("module")
DO UPDATE SET "version" = '20261111110923694-own-rows-by-id', "timestamp" = now();
--
-- MIGRATION VERSION FOR halkyon_base
--
INSERT INTO "serverpod_migrations" ("module", "version", "timestamp")
VALUES ('halkyon_base', '20261111100053843-shared-space-keys', now())
ON CONFLICT ("module")
DO UPDATE SET "version" = '20261111100053843-shared-space-keys', "timestamp" = now();
--
-- MIGRATION VERSION FOR serverpod
--
INSERT INTO "serverpod_migrations" ("module", "version", "timestamp")
VALUES ('serverpod', '20260824182259319', now())
ON CONFLICT ("module")
DO UPDATE SET "version" = '20260824182259319', "timestamp" = now();
--
-- MIGRATION VERSION FOR serverpod_auth_idp
--
INSERT INTO "serverpod_migrations" ("module", "version", "timestamp")
VALUES ('serverpod_auth_idp', '20260924105404509', now())
ON CONFLICT ("module")
DO UPDATE SET "version" = '20260924105404509', "timestamp" = now();
--
-- MIGRATION VERSION FOR serverpod_offline_sync
--
INSERT INTO "serverpod_migrations" ("module", "version", "timestamp")
VALUES ('serverpod_offline_sync', '20260914143806119', now())
ON CONFLICT ("module")
DO UPDATE SET "version" = '20260914143806119', "timestamp" = now();
--
-- MIGRATION VERSION FOR halkyon_oidc
--
INSERT INTO "serverpod_migrations" ("module", "version", "timestamp")
VALUES ('halkyon_oidc', '20261023180644988', now())
ON CONFLICT ("module")
DO UPDATE SET "version" = '20261023180644988', "timestamp" = now();
--
-- MIGRATION VERSION FOR serverpod_auth_core
--
INSERT INTO "serverpod_migrations" ("module", "version", "timestamp")
VALUES ('serverpod_auth_core', '20260924105232991', now())
ON CONFLICT ("module")
DO UPDATE SET "version" = '20260924105232991', "timestamp" = now();
COMMIT;