halkyon-days/halkyon
Watch
1
0
Fork
You've already forked halkyon
 0
Code Issues Pull requests Projects Releases 37 Packages Wiki Activity Actions

refactor(app): FeedbackPerson moves into core as PublicPerson

Browse source 
A second feature needs it: discussions name their writers as reports and
suggestions do, by what their public profile shows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tizian 「ティツィアーン」 <raisondetredev@pm.me>
This commit is contained in:
Tizian 「ティツィアーン」 2026-10-15 23:52:31 +02:00
commit 25237b8011
Signed by: raisondetredev
GPG key ID: 07F6FCF405488B64
2 changed files with 29 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

5
halkyon_learn_flutter/test/feature/feedback/feedback_repository_test.dart
View file

@ -6,6 +6,7 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:halkyon_learn_flutter/src/core/asset/data/asset_repository.dart';
import 'package:halkyon_learn_flutter/src/core/content/published_ref.dart';
import 'package:halkyon_learn_flutter/src/core/content/rich_content.dart';
import 'package:halkyon_learn_flutter/src/core/profile/public_person.dart';
import 'package:halkyon_learn_flutter/src/feature/card/data/card_repository.dart';
import 'package:halkyon_learn_flutter/src/feature/card/model/card_content.dart';
import 'package:halkyon_learn_flutter/src/feature/feedback/data/feedback_repository.dart';
@ -148,7 +149,7 @@ void main() {
studysetTitle: 'Japanese',
location: 'halkyon.eu/@alice/japanese',
kind: FeedbackKind.suggestion,
writer: const FeedbackPerson(handle: 'bob'),
writer: const PublicPerson(handle: 'bob'),
target: FeedbackTarget(
kind: FeedbackTargetKind.card,
item: id,
@ -193,7 +194,7 @@ void main() {
studysetTitle: 'Japanese',
location: 'halkyon.eu/@alice/japanese',
kind: FeedbackKind.suggestion,
writer: const FeedbackPerson(handle: 'bob'),
writer: const PublicPerson(handle: 'bob'),
target: const FeedbackTarget(
kind: FeedbackTargetKind.note,
item: 'gone',

3
halkyon_learn_flutter/test/feature/feedback/feedback_widgets_test.dart
View file

@ -1,6 +1,7 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:halkyon_learn_flutter/src/core/content/published_ref.dart';
import 'package:halkyon_learn_flutter/src/core/content/rich_content.dart';
import 'package:halkyon_learn_flutter/src/core/profile/public_person.dart';
import 'package:halkyon_learn_flutter/src/core/router/route_paths.dart';
import 'package:halkyon_learn_flutter/src/feature/auth/model/auth_status.dart';
import 'package:halkyon_learn_flutter/src/feature/card/data/card_repository.dart';
@ -36,7 +37,7 @@ FeedbackThread suggestion(String item, String back, {bool unseen = false}) =>
studysetTitle: 'Japanese',
location: 'halkyon.eu/@alice/japanese',
kind: FeedbackKind.suggestion,
writer: const FeedbackPerson(handle: 'bob', displayName: 'Bob'),
writer: const PublicPerson(handle: 'bob', displayName: 'Bob'),
target: FeedbackTarget(
kind: FeedbackTargetKind.card,
item: item,