halkyon-days/halkyon
Watch
1
0
Fork
You've already forked halkyon
 0
Code Issues Pull requests Projects Releases 40 Packages Wiki Activity Actions

fix(app): a way out when this device's data can't be opened

Browse source 
The screen that says "Couldn't open this device's data." had no button, so the person was stuck until they restarted the app. It now offers "Try again", which opens the person's data anew; a test covers a first attempt that fails and a second that works.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tizian 「ティツィアーン」 <raisondetredev@pm.me>
This commit is contained in:
Tizian 「ティツィアーン」 2026-09-30 15:13:34 +02:00
commit 231369900b
Signed by: raisondetredev
GPG key ID: 07F6FCF405488B64
2 changed files with 40 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

20
halkyon_learn_flutter/lib/src/core/dependencies/person_scope.dart
View file

@ -56,8 +56,24 @@ class _PersonScopeState() extends State<PersonScope> {
dependencies: data,
child: widget.child,
),
AsyncSnapshot(hasError: true) => const Scaffold(
body: Center(child: Text("Couldn't open this device's data.")),
AsyncSnapshot(hasError: true) => Scaffold(
body: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
const Text("Couldn't open this device's data."),
const SizedBox(height: 16),
FilledButton(
onPressed: () => setState(() {
_opening = DependenciesScope.of(
context,
).openPerson(widget.person);
}),
child: const Text('Try again'),
),
],
),
),
),
_ => const Scaffold(body: Center(child: CircularProgressIndicator())),
},

22
halkyon_learn_flutter/test/core/dependencies/person_scope_test.dart
View file

@ -56,6 +56,28 @@ void main() {
await tester.pump();
});
testWidgets('offers to try again; an attempt that works shows the app', (
tester,
) async {
var attempts = 0;
await showScope(tester, () async {
if (++attempts == 1) {
throw Exception('Disk busy');
}
return PersonDependencies(
studysets: StudysetRepository(FakeStudysetGateway()),
cards: CardRepository(FakeCardGateway()),
);
});
expect(find.text("Couldn't open this device's data."), findsOneWidget);
await tester.tap(find.text('Try again'));
await tester.pumpAndSettle();
expect(find.text('Home'), findsOneWidget);
expect(attempts, 2);
});
testWidgets("closes the person's data when it goes away", (tester) async {
var closed = false;
await showScope(