fix(app): GitHub's refusals say why, and no hint adds GitHub where passwords are offered

Where an instance offers password sign-in, GitHub is added to nobody (ADR
0017, D2), yet the start screen still said "then add GitHub" after a GitHub
account nobody has, and every refusal but an unknown account read
"Couldn't sign in with GitHub." (the end-to-end test of 21 Oct).

- The gateway tells from one read of the basics whether GitHub signs in and
  whether it is added to people (`gitHubOffer`, in place of
  `gitHubClientId`); the GitHub bloc keeps it (`Ready.linking`) for the
  profile, with why an attempt failed (`Ready.problem`).
- The instance's `usePassword`, `deprecated` and `ended` become problems of
  their own (`gitHubSignInProblemOf`), worded by `gitHubProblemText` and on
  the start screen; an anonymous person refused a link is told the GitHub
  account is nobody's and offered the password instead.
- Where passwords are offered, the start screen offers an account to create
  in place of the app's hint on adding GitHub.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tizian 「ティツィアーン」 <raisondetredev@pm.me>

packages/halkyon_app/test/auth/bloc/github_sign_in_bloc_test.dart

@@ -38,6 +38,21 @@ void main() {
     await expectLater(bloc.stream, emits(const GitHubSignInStateUnavailable()));
   });
 
+  test('offers linking no GitHub account where the instance signs people in '
+      'with a password (ADR 0017)', () async {
+    gateway.linksGitHub = false;
+    final bloc = GitHubSignInBloc(
+      AuthRepository(gateway, MemorySignInAddresses()),
+      deviceHoldsContent: () async => holdsContent,
+    )..add(const GitHubSignInEventStarted());
+    addTearDown(bloc.close);
+
+    await expectLater(
+      bloc.stream,
+      emits(const GitHubSignInStateReady(linking: false)),
+    );
+  });
+
   test('links the GitHub account to the person', () async {
     final bloc = await ready();
 
@@ -228,6 +243,60 @@ void main() {
     });
   });
 
+  test('says why the instance refused, keeping whether it links', () async {
+    gateway.linksGitHub = false;
+    final bloc = GitHubSignInBloc(
+      AuthRepository(gateway, MemorySignInAddresses()),
+      deviceHoldsContent: () async => holdsContent,
+    )..add(const GitHubSignInEventStarted());
+    addTearDown(bloc.close);
+    await expectLater(
+      bloc.stream,
+      emits(const GitHubSignInStateReady(linking: false)),
+    );
+    gateway.gitHubError = const GitHubSignInFailed(
+      GitHubSignInProblem.deprecated,
+    );
+
+    bloc.add(const GitHubSignInEventRequested());
+
+    await expectLater(
+      bloc.stream,
+      emitsInOrder([
+        const GitHubSignInStateBusy(),
+        const GitHubSignInStateReady(
+          linking: false,
+          failed: true,
+          problem: GitHubSignInProblem.deprecated,
+        ),
+      ]),
+    );
+  });
+
+  test('an anonymous person whose GitHub account now signs in with its '
+      'password is told so, and stays', () async {
+    gateway
+      ..gitHubLinkOutcome = GitHubLinkOutcome.takenByAnotherPerson
+      ..gitHubSwitchError = const GitHubSignInFailed(
+        GitHubSignInProblem.usePassword,
+      );
+    final bloc = await ready();
+
+    bloc.add(const GitHubSignInEventRequested());
+
+    await expectLater(
+      bloc.stream,
+      emitsInOrder([
+        const GitHubSignInStateBusy(),
+        const GitHubSignInStateReady(
+          failed: true,
+          problem: GitHubSignInProblem.usePassword,
+        ),
+      ]),
+    );
+    expect(gateway.status, anonymous);
+  });
+
   test('says so when signing in fails', () async {
     final bloc = await ready();
     gateway.gitHubError = Exception('No connection');

packages/halkyon_app/test/auth/bloc/session_bloc_test.dart

@@ -154,6 +154,37 @@ void main() {
     expect(gateway.gitHubSwitches, 0);
   });
 
+  test('an account that signs in with its password now, and GitHub having '
+      'ended, are each said so, signing nobody in', () async {
+    start(signedOut: true);
+    bloc.add(const SessionEventStarted());
+    await expectLater(bloc.stream, emits(const SessionStateSignedOut()));
+
+    gateway.gitHubError = const GitHubSignInFailed(
+      GitHubSignInProblem.usePassword,
+    );
+    bloc.add(const SessionEventGitHubRequested());
+    await expectLater(
+      bloc.stream,
+      emitsInOrder([
+        const SessionStateSignedOut(busy: true),
+        const SessionStateSignedOut(problem: SignedOutProblem.usePassword),
+      ]),
+    );
+
+    gateway.gitHubError = const GitHubSignInFailed(GitHubSignInProblem.ended);
+    bloc.add(const SessionEventGitHubRequested());
+    await expectLater(
+      bloc.stream,
+      emitsInOrder([
+        const SessionStateSignedOut(busy: true),
+        const SessionStateSignedOut(problem: SignedOutProblem.gitHubEnded),
+      ]),
+    );
+    expect(gateway.signIns, 0);
+    expect(gateway.gitHubSwitches, 0);
+  });
+
   test('a session the server ended asks how to start too', () async {
     const stored = SignedIn(authUserId: 'github-1', isIdentified: true);
     start(status: stored);