Commit graph appflowy-editor/test/new/block_component/table_block_component
Author SHA1 Message Date
81c3006c74
Fit a read-only table's rows to their cells
Some checks failed
Commit messages lint / commitlint (push) Has been cancelled
A table keeps each row's height on its cells, corrected after every
layout through a transaction. A read-only editor applies no transaction
(EditorState.apply returns while it isn't editable), so a table shown
read-only kept the heights it was stored with, or the default of one
line: a cell of several lines ran over its row's borders. The table's
own height (colsHeight) already took the read-only case in place; the
rows' heights now do the same. Upstream's main has the same code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MMm7usAo6q9ZZRoPkWjoxi
2026-10-11 19:40:50 +02:00
Lucas
41335c54ae
chore: merge flutter 3_27_4 into main branch (#1228)
* chore: merge flutter/3_27_4 to main branch

* chore: code format

* fix: unit tests
2026-07-27 15:37:27 +08:00
Lucas
eccb24452a
fix: cursor height is inconsistent when the font size is smaller than the default text size (#958)
* fix: cursor height is inconsistent when the font size is smaller than the default text size

* fix: widget tests
2024-11-01 13:19:17 +08:00
Lucas.Xu
44989c568e
feat: optimize the table node parse steps and add logs (#875)
* feat: optimize the table node parse steps and add logs

* feat: support table cell node construtor

* fix: widget test
2024-09-04 13:57:46 +08:00
Lucas.Xu
8e17d1447e
feat: optimize table update (#869)
* feat: optimize table update

* fix: combine the table transactions
2024-08-16 10:52:48 +08:00
Lucas.Xu
8b9ccf83fd
fix: render issue of nested list (#838)
* fix: render issue of nested list

* fix: table board doesn't show in readonly mode

* fix: ci tests
2024-07-04 16:58:57 +08:00
Lucas.Xu
796d1249fe
chore: upgrade Flutter to 3.22.0 (#797) 2024-05-14 14:05:38 +08:00
q200892907
a9ef209c55
feat: add table style (#766) 2024-04-16 15:41:08 +08:00
Ansah Mohammad
7ec43c9eee
feat: table navigation using TAB key (#627)
* feat: table navigation using TAB key

* feat: shift+tab for reverse navigation in table

* chore: circular traversal for arrow left and right

* test: added tests for tab and shift-tab commands in Table

* test: added tests for arrow left and right in table

* test: added corner case for tab and shift tab

* refactor: made changes as per the review

* refactor: Apply suggestions from code review

Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>

---------

Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>
2024-01-02 12:18:23 +08:00
Sun Jiao
ce8a77014e
fix: resolve RangeErrorwhen last row deleted. (#470) 2023-09-17 16:10:14 +08:00
Lucas.Xu
b602141d32 fix: missing a required trailing comma 2023-09-13 15:26:29 +08:00
Lucas.Xu
19f999f422
feat: optimize the performance (#442) 2023-09-11 15:03:14 +08:00
Mohammad Zolfaghari
b429ae6b96
fix: better column resize performance (#434)
* fix: table padding when it gets scrolled

The handler was getting out of region when table width was wider
than editor size.

* fix: modify scroll view padding

* fix: better column resize performance
2023-09-01 10:48:13 +08:00
Lucas.Xu
f205f8040a
fix: table block bugs (#431)
* fix: resizing the table won't send transaction

* fix: lost selection after inserting table block

* fix: test

* refactor: don't pass editorState to TableNode

pass only transaction to methods directly.

* refactor: reduce extra transactions

* fix: mitigate Appflowy transaction adapter problem

With current transaction adapter in Appflowy which creates `BlockActionPB`
for `documentService` (backend). Its not possible to have multiple
`InsertOperation`s separately as a single transaction (multiple
`transaction.insertNode()`). The `BlockActionPB` creator (`toBlockAction`)
can't figure out the `prevId` (previous node of inserting node id), The
first insert operations shifts all next nodes path.
Because of this situation we decided to apply the insert operations one by
one.

* fix: table actions keep selection

* fix: on add col|row respect row|col bg color

* refactor: moving cell related keys to TableCellBlockKeys

* style: dart format

---------

Co-authored-by: Mohammad Zolfaghari <zidom72@gmail.com>
2023-08-31 10:35:23 +08:00
Mohammad Zolfaghari
dd52ce6718
feat: table plugin (#62)
* feat: table plugin requisites

* feat: moved table plugin to appflowy-editor

* fix: flutter analyze

* fix: dont use nested maps in node attributes

rust backend (flowy-document) doesn't support it.

* feat: add table to appflowy editor default selection menu

* feat table markdown encoder

* refactor: apply @Xazin review suggestions

* refactor: merge main and fix color picker conflicts

* feat: table markdown decoder

* fix: use specific backgroun generator for table

* feat: table plugin

* style: adapt new structure

* fix: table columns border height

* fix: adapt new style key commands

* fix: remove table context menu

* test: adapt to main branch changes

* fix: backspace handling regarding table

* fix: flutter analyze

* fix: enter when table cell is bullet list

* fix: selection bug on large table

* feat: row/col action menu

* fix: row action handler positioning

* refactor: merge row and col handler widget

* refactor: add size and color to handler icon

* style(merge): merge main

* feat: added padding and action wrapper

* feat: enable customizing icons and etc

* feat: table menu builder

* fix: table getBlockRect

* refactor: table action button design

---------

Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>
2023-08-29 15:24:25 +08:00