halkyon-days/appflowy-editor
Watch
1
0
Fork
You've already forked appflowy-editor
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: support customizing link button (#1048)

Browse source
This commit is contained in:
Lucas 2025-03-03 16:53:25 +08:00 • committed by GitHub
commit b2672f297b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/src/editor/editor_component/service/shortcuts/command/open_link_command.dart
View file

@ -38,7 +38,7 @@ KeyEventResult _openInlineLink(
} }
if (linkText != null) { if (linkText != null) {
safeLaunchUrl(linkText); editorLaunchUrl(linkText);
} }
return KeyEventResult.handled; return KeyEventResult.handled;

2
lib/src/editor/editor_component/style/default_text_span_decorator_for_attribute.dart
View file

@ -37,7 +37,7 @@ TextSpan defaultTextSpanDecoratorForAttribute(
HardwareKeyboard.instance.isControlPressed || HardwareKeyboard.instance.isControlPressed ||
HardwareKeyboard.instance.isMetaPressed) { HardwareKeyboard.instance.isMetaPressed) {
tapCount = 0; tapCount = 0;
safeLaunchUrl(href); editorLaunchUrl(href);
return; return;
} }
timer = Timer(const Duration(milliseconds: 200), () { timer = Timer(const Duration(milliseconds: 200), () {

2
lib/src/editor/toolbar/desktop/items/link/link_toolbar_item.dart
View file

@ -92,7 +92,7 @@ void showLinkMenu(
linkText: linkText, linkText: linkText,
editorState: editorState, editorState: editorState,
onOpenLink: () async { onOpenLink: () async {
await safeLaunchUrl(linkText); await editorLaunchUrl(linkText);
}, },
onSubmitted: (text) async { onSubmitted: (text) async {
if (isUri(text)) { if (isUri(text)) {

2
lib/src/extensions/url_launcher_extension.dart
View file

@ -12,3 +12,5 @@ Future<bool> safeLaunchUrl(String? href) async {
} }
return Future.value(true); return Future.value(true);
} }
Future<bool> Function(String? href) editorLaunchUrl = safeLaunchUrl;

2
test/extensions/url_launcher_extension_test.dart
View file

@ -4,7 +4,7 @@ import 'package:flutter_test/flutter_test.dart';
void main() { void main() {
test('safeLaunchUrl without href and scheme', () async { test('safeLaunchUrl without href and scheme', () async {
const href = null; const href = null;
final result = await safeLaunchUrl(href); final result = await editorLaunchUrl(href);
expect(result, false); expect(result, false);
}); });
} }

2
test/mobile/editor/editor_component/style/mobile_text_span_decorator_for_attribute_test.dart
View file

@ -27,7 +27,7 @@ void main() {
await widgetTester.pumpAndSettle(); await widgetTester.pumpAndSettle();
// test the method only // test the method only
expect(() => safeLaunchUrl(address), returnsNormally); expect(() => editorLaunchUrl(address), returnsNormally);
}, },
); );
testWidgets( testWidgets(