halkyon-days/appflowy-editor
Watch
1
0
Fork
You've already forked appflowy-editor
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: slash menu sometimes incorrectly show on left side (#1082)

Browse source
This commit is contained in:
Morn 2025-03-27 13:43:03 +08:00 • committed by GitHub
commit 5ad9d771a8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
lib/src/editor/selection_menu/selection_menu_service.dart
View file

@ -27,6 +27,8 @@ class SelectionMenu extends SelectionMenuService {
this.style = SelectionMenuStyle.light,
this.itemCountFilter = 0,
this.singleColumn = false,
this.menuHeight = 300,
this.menuWidth = 300,
});
final BuildContext context;
@ -35,6 +37,8 @@ class SelectionMenu extends SelectionMenuService {
final bool deleteSlashByDefault;
final bool deleteKeywordsByDefault;
final bool singleColumn;
final double menuHeight;
final double menuWidth;
@override
final SelectionMenuStyle style;
@ -207,7 +211,6 @@ class SelectionMenu extends SelectionMenuService {
// Workaround: We can customize the padding through the [EditorStyle],
// but the coordinates of overlay are not properly converted currently.
// Just subtract the padding here as a result.
const menuHeight = 300.0;
const menuOffset = Offset(0, 10);
final editorOffset =
editorState.renderBox?.localToGlobal(Offset.zero) ?? Offset.zero;
@ -235,8 +238,14 @@ class SelectionMenu extends SelectionMenuService {
);
}
// show on left
if (_offset.dx - editorOffset.dx > editorWidth / 2) {
// show on right
if (_offset.dx + menuWidth < editorOffset.dx + editorWidth) {
_offset = Offset(
_offset.dx,
_offset.dy,
);
} else if (offset.dx - editorOffset.dx > menuWidth) {
// show on left
_alignment = _alignment == Alignment.topLeft
? Alignment.topRight
: Alignment.bottomRight;