halkyon-days/appflowy-editor
Watch
1
0
Fork
You've already forked appflowy-editor
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: impossible to click on any sub-items if the top level item is off-screen (#522)

Browse source
This commit is contained in:
Lucas.Xu 2023-10-09 22:02:23 +08:00 • committed by GitHub
commit 0abcf7f6d2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/src/editor/editor_component/service/selection/desktop_selection_service.dart
View file

@ -1,3 +1,5 @@
import 'dart:math' as math;
import 'package:appflowy_editor/appflowy_editor.dart'; import 'package:appflowy_editor/appflowy_editor.dart';
import 'package:appflowy_editor/src/flutter/overlay.dart'; import 'package:appflowy_editor/src/flutter/overlay.dart';
import 'package:appflowy_editor/src/service/selection/selection_gesture.dart'; import 'package:appflowy_editor/src/service/selection/selection_gesture.dart';
@ -156,7 +158,8 @@ class _DesktopSelectionServiceWidgetState
final List<Node> sortedNodes = []; final List<Node> sortedNodes = [];
final positions = final positions =
context.read<EditorScrollController>().visibleRangeNotifier.value; context.read<EditorScrollController>().visibleRangeNotifier.value;
final min = positions.$1; // https://github.com/AppFlowy-IO/AppFlowy/issues/3651
final min = math.max(positions.$1 - 1, 0);
final max = positions.$2; final max = positions.$2;
if (min < 0 || max < 0) { if (min < 0 || max < 0) {
return sortedNodes; return sortedNodes;